Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add iterators #4

Closed
wants to merge 2 commits into from
Closed

feat: add iterators #4

wants to merge 2 commits into from

Conversation

willothy
Copy link
Member

@willothy willothy commented Nov 3, 2024

Important

Add Iter struct and implement Iterator trait for ShardMap to support iteration over key-value pairs.

  • Behavior:
    • Add Iter struct in src/iter.rs to iterate over ShardMap key-value pairs.
    • Implement Iterator trait for Iter to support iteration.
    • Add iter() method to ShardMap in src/shard_map.rs to return an Iter instance.
  • Tests:
    • Add test_iter and test_iter_empty in src/iter.rs to verify iterator functionality.
  • Misc:
    • Add read_sync() and write_sync() methods to Shard in src/shard.rs for synchronous access.
    • Remove path filters from .github/workflows/rust.yml for pull requests.

This description was created by Ellipsis for bf7ffd8. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to dc57679 in 1 minute and 0 seconds

More details
  • Looked at 177 lines of code in 4 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_NpQRdI0fAY3VA8UB


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

src/iter.rs Show resolved Hide resolved
src/iter.rs Show resolved Hide resolved
src/iter.rs Show resolved Hide resolved
src/iter.rs Show resolved Hide resolved
@willothy willothy marked this pull request as draft November 3, 2024 07:28
@willothy willothy marked this pull request as ready for review November 3, 2024 07:29
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Incremental review on bf7ffd8 in 21 seconds

More details
  • Looked at 17 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_i0eZfwB0oHKXPqFs


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@@ -12,12 +12,6 @@ on:

pull_request:
branches: [ "main" ]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider re-adding the 'paths' specification to limit workflow runs to relevant changes, preventing unnecessary executions.

@willothy willothy marked this pull request as draft November 3, 2024 09:30
@willothy willothy closed this Nov 4, 2024
@willothy willothy deleted the iter branch November 4, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant